Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure podAnnotations are removed from pods if reset in the config #2826

Merged
merged 9 commits into from
Jan 24, 2025
Merged

Ensure podAnnotations are removed from pods if reset in the config #2826

merged 9 commits into from
Jan 24, 2025

Conversation

hughcapet
Copy link
Member

fix use case when an annotation is removed from the podAnnotations setting (should be reflected for the running Pods and Pod templates)

@hughcapet hughcapet force-pushed the fix/pod-annotations-removal branch from 799c015 to 93d718e Compare December 23, 2024 19:17
@hughcapet hughcapet marked this pull request as ready for review December 30, 2024 08:34
@hughcapet hughcapet force-pushed the fix/pod-annotations-removal branch from 93d718e to 2c9ceed Compare January 3, 2025 16:35
@idanovinda
Copy link
Member

👍

FxKu
FxKu reviewed Jan 7, 2025
View reviewed changes
@hughcapet hughcapet marked this pull request as draft January 12, 2025 19:51
@hughcapet hughcapet marked this pull request as ready for review January 16, 2025 09:16
@FxKu FxKu added this to the 1.15.0 milestone Jan 17, 2025
@hughcapet hughcapet force-pushed the fix/pod-annotations-removal branch from 1adac71 to 3d45891 Compare January 22, 2025 10:35
FxKu
FxKu reviewed Jan 23, 2025
View reviewed changes
FxKu
FxKu reviewed Jan 24, 2025
View reviewed changes
@FxKu
Copy link
Member

FxKu commented Jan 24, 2025

👍

1 similar comment
@hughcapet
Copy link
Member Author

👍

@hughcapet hughcapet merged commit f49b4f1 into master Jan 24, 2025
10 checks passed
@hughcapet hughcapet deleted the fix/pod-annotations-removal branch January 24, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FxKu FxKu FxKu left review comments

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@jopadi jopadi Awaiting requested review from jopadi jopadi is a code owner

@idanovinda idanovinda Awaiting requested review from idanovinda idanovinda is a code owner

@macedigital macedigital Awaiting requested review from macedigital macedigital is a code owner

Assignees
No one assigned
Labels
bugfix
Projects
Postgres Operator
Status: Done
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hughcapet @idanovinda @FxKu